[ 
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827304#comment-15827304
 ] 

ASF GitHub Bot commented on GEARPUMP-252:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/133#discussion_r96554180
  
    --- Diff: 
core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala ---
    @@ -161,13 +172,24 @@ class ClientContext(config: Config, sys: ActorSystem, 
_master: ActorRef) {
         fullName
       }
     
    -  private def getMasterClient: MasterClient = {
    -    val timeout = 
Try(config.getInt(Constants.GEARPUMP_MASTERCLIENT_TIMEOUT)).getOrElse(90)
    -    new MasterClient(master, akka.util.Timeout(timeout, TimeUnit.SECONDS))
    +  private def submitApplication(submitApplication: SubmitApplication): 
RunningApplication = {
    +    val result = ActorUtil.askActor[SubmitApplicationResult](master,
    +      submitApplication, masterClientTimeout)
    +    val application = result.appId match {
    +      case Success(appId) =>
    +        // scalastyle:off println
    +        Console.println(s"Submit application succeed. The application id 
is $appId")
    +        // scalastyle:on println
    +        new RunningApplication(appId, master, masterClientTimeout)
    +      case Failure(ex) => throw ex
    +    }
    +    application
       }
     }
     
     object ClientContext {
    +  // This magic number is derived from Akka's configuration
    +  final val INFINITE_TIMEOUT = Timeout(2147482, TimeUnit.SECONDS)
    --- End diff --
    
    which configuration ? Any links ?


> return application status to client
> -----------------------------------
>
>                 Key: GEARPUMP-252
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-252
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Huafeng Wang
>
> Currently, client exits after submitting applications and has no idea of the 
> application status. It will be valuable to return such information to client. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to