[ 
https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833823#comment-15833823
 ] 

ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97245683
  
    --- Diff: 
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala 
---
    @@ -40,6 +44,12 @@ class RunningApplication(val appId: Int, master: 
ActorRef, timeout: Timeout) {
         }
       }
     
    +  def waitUnilFinish(): ApplicationResult = {
    --- End diff --
    
    I don't think `ApplicationResult` should be exposed to client since it's an 
internal interface.


> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
>                 Key: GEARPUMP-265
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-265
>             Project: Apache Gearpump
>          Issue Type: Sub-task
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to