[ 
https://issues.apache.org/jira/browse/GEARPUMP-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834215#comment-15834215
 ] 

ASF GitHub Bot commented on GEARPUMP-252:
-----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97287682
  
    --- Diff: 
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala 
---
    @@ -40,6 +44,16 @@ class RunningApplication(val appId: Int, master: 
ActorRef, timeout: Timeout) {
         }
       }
     
    +  def waitUnilFinish(): Unit = {
    +    val delegator = system.actorOf(Props(new AppResultListener(appId, 
master)))
    +    val result = ActorUtil.askActor[ApplicationResult](delegator, 
WaitUntilFinish, INF_TIMEOUT)
    +    result match {
    +      case failed: ApplicationFailed =>
    +        throw failed.error
    +      case _ =>
    +    }
    +  }
    +
       def askAppMaster[T](msg: Any): Future[T] = {
    --- End diff --
    
    The ActorUtil's askAppMaster will first `ResolveAppId` which is unnecessary 
here.


> return application status to client
> -----------------------------------
>
>                 Key: GEARPUMP-252
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-252
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Huafeng Wang
>
> Currently, client exits after submitting applications and has no idea of the 
> application status. It will be valuable to return such information to client. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to