Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97263412
  
    --- Diff: 
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
    @@ -142,4 +139,26 @@ case class ExecutorContext(
     case class ExecutorJVMConfig(
         classPath: Array[String], jvmArguments: Array[String], mainClass: 
String,
         arguments: Array[String], jar: Option[AppJar], username: String,
    -    executorAkkaConfig: Config = ConfigFactory.empty())
    \ No newline at end of file
    +    executorAkkaConfig: Config = ConfigFactory.empty())
    +
    +sealed abstract class ApplicationStatus(val status: String)
    +  extends Serializable{
    +  override def toString: String = status
    +}
    +
    +sealed abstract class ApplicationTerminalStatus(override val status: 
String)
    +  extends ApplicationStatus(status)
    +
    +object ApplicationStatus {
    +  case object PENDING extends ApplicationStatus("pending")
    +
    +  case object ACTIVE extends ApplicationStatus("active")
    +
    +  case object SUCCEEDED extends ApplicationTerminalStatus("succeeded")
    +
    +  case object FAILED extends ApplicationTerminalStatus("failed")
    +
    +  case object TERMINATED extends ApplicationTerminalStatus("terminated")
    +
    +  case object NOEXIST extends ApplicationStatus("nonexist")
    --- End diff --
    
    `noexist` or `nonexist` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to