[ https://issues.apache.org/jira/browse/GEARPUMP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112714#comment-16112714 ]
ASF GitHub Bot commented on GEARPUMP-338: ----------------------------------------- GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/208 [GEARPUMP-338] Improve time related types and constants Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump fix_time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #208 ---- commit 82ee3711be5c84bb08ae530de4be5631cf1819c1 Author: manuzhang <owenzhang1...@gmail.com> Date: 2017-08-03T13:43:03Z [GEARPUMP-338] Improve time related types and constants ---- > Improve time related types and constants > ---------------------------------------- > > Key: GEARPUMP-338 > URL: https://issues.apache.org/jira/browse/GEARPUMP-338 > Project: Apache Gearpump > Issue Type: Improvement > Affects Versions: 0.8.4 > Reporter: Manu Zhang > Assignee: Manu Zhang > Fix For: 0.8.5 > > > Currently, there is a type {{TimeStamp}} in package object {{gearpump}}. It's > unclear what the time unit is, seconds or milliseconds. There are also > constants {{MAX_TIME_MILLIS}} and {{MIN_TIME_MILLIS}} for maximum and minimum > valid timestamps in milliseconds. All of them are not easy to find out and > import from the package object. > Propose to move them into a new object singleton {{Time}} and rename type > {{TimeStamp}} to {{MilliSeconds}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)