----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53856/#review156223 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java (line 154) <https://reviews.apache.org/r/53856/#comment226387> This could be replaced with awaitility. - Dan Smith On Nov. 17, 2016, 6:06 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53856/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 6:06 p.m.) > > > Review request for geode, Darrel Schneider and Dan Smith. > > > Bugs: geode-2120 > https://issues.apache.org/jira/browse/geode-2120 > > > Repository: geode > > > Description > ------- > > The test waited for up to 5 seconds for the compaction, usually it only took > 30ms to finish. However, sometimes in concurse, it did took more than 5 > seconds to finish (In the reproduced failure, it took 7 seconds). > > The fix is to wait longer. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java > 1f61be3 > > Diff: https://reviews.apache.org/r/53856/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
