----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/ -----------------------------------------------------------
(Updated Nov. 28, 2016, 11:27 p.m.) Review request for geode, Kevin Duling, Kirk Lund, and Udo Kohlmeyer. Changes ------- Added the ignored tests back and fix the issues brought up in the review Repository: geode Description ------- * add the "disconnect" command when we close the GfshShellConnectionRule so that no heartbeat thread is left to pollute other tests. * Fix the test so that it truely test the jmx ssl connection, and fix the configuration mishaps. * The above fix revealed another bug (GEODE-2099: race condition), ignored the other two tests for now. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java c58a398ef9094ceecde2d7c6e806931dff872552 geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java 3a2660cca88a0ae4070eab7c496e2079bfb63a7d geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java 3731d4d19ea7227d91e9714ccf2b56424098aaf3 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/JmxOperationInvoker.java 0fa47d434d599de81acebc275175eb087e9deb79 geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 0c16c1a628a4785bba302ed651e3017e2ce7a563 Diff: https://reviews.apache.org/r/53685/diff/ Testing ------- Thanks, Jinmei Liao
