Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/308#discussion_r91988138
  
    --- Diff: 
geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java ---
    @@ -48,8 +49,10 @@
       public void loadExpectedJars() throws IOException {
         String expectedJarFile =
    --- End diff --
    
    Would it be better to move the check into TestUtil.getResourcePath? so that 
the caller do not have to worry about the platform?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to