[ 
https://issues.apache.org/jira/browse/GEODE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749377#comment-15749377
 ] 

Dan Smith commented on GEODE-1272:
----------------------------------

I have a test that shows that we definitely are *not* calling 
DefaultQuery.setPdxReadSerialized, because I'm seeing entries get deserialized 
when creating an index.

> IndexManager.populateIndexes(Collection) may deserialize pdx to domain objects
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-1272
>                 URL: https://issues.apache.org/jira/browse/GEODE-1272
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Darrel Schneider
>            Assignee: Dan Smith
>
> Looking at the IndexManager.populateIndexes I see it iterating over all the 
> entries in a region and adding each entry to each index. What is unclear is 
> if this code correctly calls DefaultQuery.setPdxReadSerialized before 
> accessing the value from the entry. Please verify that when this code is used 
> it will not deserialize pdx to domain object.
> Note that the code currently calls RegionEntry.getValue for every entry and I 
> thought that might be a problem. But since getValue just returns the 
> VMCachedDeserializable and does not try to deserialize the value it wraps it 
> does not cause a problem. So the only issue would be what happens each each 
> entry is passed to AbstractIndex.addIndexMapping.
> I looked the callers of IndexManager.populateIndexes and could not find them 
> calling DefaultQuery.setPdxReadSerialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to