Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92545081
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.management.internal.configuration;
+
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.test.dunit.rules.ClusterConfig;
+import org.apache.geode.test.dunit.rules.ConfigGroup;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.Locator;
+import org.apache.geode.test.dunit.rules.Server;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.zip.ZipEntry;
+import java.util.zip.ZipFile;
+
+@Category(DistributedTest.class)
+public class ClusterConfigImportDUnitTest extends ClusterConfigBaseTest {
+ private GfshShellConnectionRule gfshConnector;
+
+ public static final ClusterConfig INITIAL_CONFIG = new ClusterConfig(new
ConfigGroup("cluster"));
+
+ private Locator locator;
+
+ @Before
+ public void before() throws Exception {
+ super.before();
+ locator = lsRule.startLocatorVM(0, locatorProps);
+ INITIAL_CONFIG.verify(locator);
+
+ gfshConnector = new GfshShellConnectionRule(locator);
+ gfshConnector.connect();
+ assertThat(gfshConnector.isConnected()).isTrue();
+ }
+
+
+ @After
+ public void after() throws Exception {
+ if (gfshConnector != null) {
+ gfshConnector.close();
+ }
+ }
+
+ @Test
+ public void testImportWithRunningServer() throws Exception {
+ Server server1 = lsRule.startServerVM(1, serverProps,
locator.getPort());
+
+ CommandResult result = gfshConnector.executeCommand(
+ "import cluster-configuration --zip-file-name=" +
EXPORTED_CLUSTER_CONFIG_PATH);
+
+ assertThat(result.getStatus()).isEqualTo(Result.Status.ERROR);
+ }
+
+ @Test
+ public void testImportClusterConfig() throws Exception {
+ CommandResult result = gfshConnector.executeCommand(
+ "import cluster-configuration --zip-file-name=" +
EXPORTED_CLUSTER_CONFIG_PATH);
+ assertThat(result.getStatus()).isEqualTo(Result.Status.OK);
+
+ // verify that the previous folder is backed up to
"cluster_configxxxxxx".
+ assertThat(locator.getWorkingDir().listFiles())
+ .filteredOn((File file) ->
!file.getName().equals("cluster_config"))
+ .filteredOn((File file) ->
file.getName().startsWith("cluster_config")).isNotEmpty();
+ CONFIG_FROM_ZIP.verify(locator);
+
+ // start server1 with no group
+ Server server1 = lsRule.startServerVM(1, serverProps,
locator.getPort());
+ new ClusterConfig(CLUSTER).verify(server1);
+
+ // start server2 in group1
+ serverProps.setProperty(GROUPS, "group1");
+ Server server2 = lsRule.startServerVM(2, serverProps,
locator.getPort());
+ new ClusterConfig(CLUSTER, GROUP1).verify(server2);
+
+ // start server3 in group1 and group2
+ serverProps.setProperty(GROUPS, "group1,group2");
+ Server server3 = lsRule.startServerVM(3, serverProps,
locator.getPort());
+ new ClusterConfig(CLUSTER, GROUP1, GROUP2).verify(server3);
+ }
+
+ @Test
+ public void testExportClusterConfig() throws Exception {
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
