Github user metatype commented on the issue:
https://github.com/apache/geode/pull/325
Thanks for the contribution. However, I'm currently -1 until you clarify
the purpose of the change and follow some of the recommendations included in
our project contribution guidelines such as:
- You need to file a JIRA for any change to the code base. This helps
drive discussion / consensus and makes it easy to do release notes.
- Separate code reformatting changes from actual logic changes. This makes
it easier to review.
- Don't include \@author tags
- Use `git rebase -i` to squash commits like 'this is a test'. We only
want to see useful commits in our git history
- We use spotless to manage the source code formatting. If you want to
change the format, please start a discussion on the dev@geode list.
See the wiki pages for more details:
https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute
Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
