> On Dec. 22, 2016, 6:34 p.m., Bruce Schuchardt wrote: > > I think you should save the system properties in a @Before and restore them > > in an @After
Just add RestoreSystemProperties as a JUnit Rule: @Rule public RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties(); The Rule takes a snapshot of the system properties in before and restores them in after. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54945/#review159990 ----------------------------------------------------------- On Dec. 21, 2016, 7:25 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54945/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 7:25 p.m.) > > > Review request for geode, Bruce Schuchardt and Kirk Lund. > > > Repository: geode > > > Description > ------- > > If ssl is enabled but neither ssl-keystore or cluster-ssl-keystore properties > are set, the ssl configuration behavior should be to fail over to javas > properties (if provided). This seemed not to work in the previous ssl > configuration implementation, but seems to be now fixed in the newer > SSLConfiguration implementation. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java > aa61ca36e > > geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java > 38d4d87b3 > > Diff: https://reviews.apache.org/r/54945/diff/ > > > Testing > ------- > > Added test to test scenario. No code was changed for this. > > > Thanks, > > Udo Kohlmeyer > >
