So you envision a world where someone who doesn't care about native clients
must build the native clients as part of the root gradle build and a person
not interested in building the Java bits must you gradle to build the
native clients?
Both those scenarios don't sound great to me. As a developer only
interested in one of the component of project I really don't want to have
to build them all to get one. I would actually use that to echo Mark's
suggestion of a separate repo. Especially as a native developer I would not
want to have all the dependencies of server project in my environment just
to build native bits. Even worse would be requiring someone only interested
in the Java bits to meet all the dependencies of the native build.
Am I misunderstanding what you are suggesting?
On Mon, Jan 16, 2017 at 11:04 AM Anthony Baker <aba...@pivotal.io> wrote:
>
> > On Jan 15, 2017, at 2:24 AM, Avinash Dongre <adon...@apache.org> wrote:
> >
> > This is great.
> >
> > Need to make following change to PASS the build.
> >
> >
> > diff --git a/src/tests/javaobject/CMakeLists.txt
> > b/src/tests/javaobject/CMakeLists.txt
> > index 4924e5c..7f85878 100644
> > --- a/src/tests/javaobject/CMakeLists.txt
> > +++ b/src/tests/javaobject/CMakeLists.txt
> > @@ -9,8 +9,8 @@ get_filename_component(JAVA_HOME ${JAVA_BIN} DIRECTORY)
> >
> > # Update the class path.
> > set(CMAKE_JAVA_INCLUDE_PATH ${JAVA_HOME}/lib/tools.jar)
> > -if (GEMFIRE_HOME)
> > - LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> > ${GEMFIRE_HOME}/lib/geode-core-9.0.0.jar)
> > +if (DEFINED ENV{GEMFIRE_HOME})
> > + LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> > $ENV{GEMFIRE_HOME}/lib/geode-core-1.0.0-incubating.jar)
> > else()
> > LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> "/gemfire/lib/geode-core-9.0.0.jar")
> > endif()
> >
> >
> > Also need to update the src/BUILDING.md for instruction to download geode
> > build from [1] and set GEMFIRE_HOME ( which I think should be changed to
> > GEODE_HOME )
> >
> > *OPTION 2*
> > Add Geode Jars as external dependency and update CMakeFile accordingly
> to
> > download as done for other dependencies
> >
> >
> > Thanks
> > Avinash
> >
> > [1]
> >
> http://www-eu.apache.org/dist/geode/1.0.0-incubating/apache-geode-1.0.0-incubating.tar.gz
> >
> >
> >>
> >>
>
> I think BUILDING.md needs a few corrections:
>
> 1) When you do `mkdir build` you need to also `cd build`.
> 2) doxygen is not an optional install, it was required in order to
> generate the cmake environment.
> 3) Need to add a step for setting GEMFIRE_HOME.
> 4) Would be nice to use a parallel build option to speed up compilation.
>
> As we integrate this into the geode build, I would like to be able to run
> a single top-level command that builds both geode and these client drivers,
> without the need to precreate dirs or setup environment vars.
>
> Anthony
>
>
