----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55603/#review161817 -----------------------------------------------------------
Ship it! geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationExtensionsDUnitTest.java (line 142) <https://reviews.apache.org/r/55603/#comment233123> The value of NAME should be a String. - Kirk Lund On Jan. 17, 2017, 5:03 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55603/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 5:03 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * separte the failing tests. Put WAN test into WAN's test and another into > core's test > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java > d72e38633dae1b68136c6bc99bb2620f401ee41a > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 718c816fc6d4d35cae0e286078638a5dfdc494ed > > geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationExtensionsDUnitTest.java > f9786c7f85eedd3eb1a358aae8f3a8fbcb9a61f4 > > geode-wan/src/test/java/org/apache/geode/management/internal/configuration/WanDUnitTest.java > c1aeae639b961f7e653d3c7e8c9ed153effeba36 > > Diff: https://reviews.apache.org/r/55603/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
