----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55644/#review161982 -----------------------------------------------------------
Ship it! OMG!! Did you see the GatewayReceiverCommand.cmdExecute method... Why would we not have refactored at 700 line long method... made it really hard to follow the flow of the fix. Maybe we need to open a ticket for this refactor. - Udo Kohlmeyer On Jan. 17, 2017, 9:23 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55644/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 9:23 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Now pdxEvent from gateway added through pdx Type registry > > This make sure that we have one mechanism to add pdx type into pdx > registry. Added test for it(From Bruce). > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java > 7a7669f > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > 54140bd > geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableDUnitTest.java > 9ebf5b2 > > Diff: https://reviews.apache.org/r/55644/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
