-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55742/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 11:31 p.m.)
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
Changes
-------
Make AcceptorImplObserver an interface, fix threading issues.
Bugs: GEODE-2324
https://issues.apache.org/jira/browse/GEODE-2324
Repository: geode
Description
-------
[GEODE-2324] fix AcceptorImpl cleanup.
* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid similar mistakes in the future.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut down
twice.
* Fix what looks like a bug where if closing the socket throws and IOException,
we fail to shut anything else down, though we still have ourselves marked as
shut down.
I'm a little skeptical of whether we're waiting at all for the queue to shut
down, as the thread could have been marked as interrupted for quite a while
before and never noticed it until the thread got parked. This may warrant more
investigation.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
060683de6
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AcceptorImplObserver.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplDUnitTest.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplJUnitTest.java
7aa11b7ca
Diff: https://reviews.apache.org/r/55742/diff/
Testing
-------
precheckin passed on (3), will run on (5).
Thanks,
Galen O'Sullivan
