> On Jan. 30, 2017, 3:28 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java, > > line 405 > > <https://reviews.apache.org/r/56099/diff/1/?file=1619366#file1619366line405> > > > > What if just one of them is null? Do we want to do this "if (userName > > == null || passwordToUse == null)" instead?
That is already handled. This bit of code is within the execption clause of a situation like that. This is the UX: $ gfsh -e "connect --user=admin" (1) Executing - connect --user=admin password must be specified. $ gfsh -e "connect --password=secret" (1) Executing - connect --password=***** Connecting to Locator at [host=localhost, port=10334] .. Connecting to Manager at [host=192.168.1.187, port=1099] .. Could not connect to : [host=192.168.1.187, port=1099]. Missing Credentials. Please supply username/password. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56099/#review163587 ----------------------------------------------------------- On Jan. 30, 2017, 3:24 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56099/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 3:24 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2250: gfsh -e connect will throw java.lang.StackOverflowError rather > than prompt for username/password > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 267746456f0d9cb9df510818c92f2479487aeadd > > Diff: https://reviews.apache.org/r/56099/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Kevin Duling > >
