----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55738/#review163731 -----------------------------------------------------------
I wish we threw checked exceptions. That's probably an issue for another day. Run spotless and then SHIP IT! geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java (line 108) <https://reviews.apache.org/r/55738/#comment235223> Did you intentionally add two lines before the semicolon here? geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java (line 240) <https://reviews.apache.org/r/55738/#comment235229> +1 braces. It might be nice to fix the capitalization on `ObJECT_START`, just like, to make things look better around the place. geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java (line 725) <https://reviews.apache.org/r/55738/#comment235239> Don't forget to run spotless so that the build passes, even though it will ruin your formatting. - Galen O'Sullivan On Jan. 20, 2017, 4:45 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55738/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 4:45 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh > Khamesra. > > > Repository: geode > > > Description > ------- > > Remove duplicate code from the JSONFormatter.fromJSON method > cleaned up some testing code and fixed a classcast issue > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java 9ee32c913 > geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java > 7fd6cf2c5 > > Diff: https://reviews.apache.org/r/55738/diff/ > > > Testing > ------- > > precheckin - running > > > Thanks, > > Udo Kohlmeyer > >
