----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/#review163741 -----------------------------------------------------------
The only thing that concerns me about this change-set is the auto-boxing/unboxing that's going on with the new method. The old code didn't do that. - Bruce Schuchardt On Jan. 20, 2017, 4:50 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55736/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 4:50 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh > Khamesra. > > > Repository: geode > > > Description > ------- > > the add fields have the same behavior and identical code. Refactored the code > to use a single method and reduce duplication > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java > 39d16a57e > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java > 7f510da15 > > geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java > 396eb1d13 > > Diff: https://reviews.apache.org/r/55736/diff/ > > > Testing > ------- > > precheckin - passed > > > Thanks, > > Udo Kohlmeyer > >
