----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56002/ -----------------------------------------------------------
(Updated Feb. 1, 2017, 1:54 a.m.) Review request for geode, Darrel Schneider, Eric Shu, Ken Howe, and Swapnil Bawaskar. Changes ------- Added additional test as per review comments. Repository: geode Description ------- GEODE-1672: out of memory during recovery with overflow regions (heap LRU configured). When recovering the persistent files, GEODE stores the values into temp maps (for regions) using a background thread, as these maps are not actual regions, these are not considered/included for LRU eviction, which causes the system to run OOM. The problem is fixed by skipping recovering the values for LRU regiuons. A new system property ""disk.recoverLruValues" is added to support reading values for lru regions. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 5affdb5 geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 32d6e30 geode-core/src/test/java/org/apache/geode/internal/cache/DiskLruRegRecoveryJUnitTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java 6a5c338 geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionHelperFactory.java fa68044 geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionProperties.java 19662bf geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java b0170e1 Diff: https://reviews.apache.org/r/56002/diff/ Testing ------- Added new test. Run existing disk tests. Thanks, anilkumar gingade
