----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56506/#review165186 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java (line 5267) <https://reviews.apache.org/r/56506/#comment237002> I don't like that if this code retries it keeps seeking back in the file and possible rewrites bytes it already wrote. I also don't like that the old code did not check for all the data to have been written. Lets talk about this one. - Darrel Schneider On Feb. 9, 2017, 10:11 a.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56506/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 10:11 a.m.) > > > Review request for geode, anilkumar gingade and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > Implemented limited retries in two forms of Oplog.flush() when > channel.write() is called. > If write() returns bytes witten less than the change in the ByteBuffer > positions, then reset > buffer positions and re-try writing for a limited number of times. Throws > IOException if the write doesn't succeeded after a few retries (max > number of retries is defined by a static). > > Added new unit tests. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > 0b98364b743c39e69773d586f9c793eb7de71b8d > > geode-core/src/test/java/org/apache/geode/internal/cache/OplogFlushTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56506/diff/ > > > Testing > ------- > > Started precheckin > > > Thanks, > > Ken Howe > >
