Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100904404
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
throw CacheXmlException(s.c_str());
}
- ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+ std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --
Maybe this would be better as a separate pull request for fixing all
c-style casts? However, if you feel it's more effective to update them
incrementally as we make changes then I will add them to this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
