----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56635/ -----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken Howe. Bugs: GEODE-2481 https://issues.apache.org/jira/browse/GEODE-2481 Repository: geode Description ------- GEODE-2481: extract default properties generation to its own class While refactoring GemFireVersion for GEODE-2474, I noticed that GemFireVersionIntegrationJUnitTest has nothing to do with GemFireVersion. Extract generation of default properties to DefaultPropertiesGenerator. Rename GemFireVersionIntegrationJUnitTest to DefaultPropertiesGeneratorIntegrationTest. Note: I have several changes on feature/GEODE-2474 branch which I'll separate into multiple reviews. I'll do a final precheckin on the entire branch and then merge the changes in after everything passes review and precheckin. DistributionConfig and DefaultPropertiesGenerator should eventually move to a configuration package, but I don't really want to combine anything that big with this change. Diffs ----- geode-assembly/build.gradle f34688043dd3e6bf8e8bdf0cb223d533b692e301 geode-core/src/main/java/org/apache/geode/distributed/internal/DefaultPropertiesGenerator.java PRE-CREATION geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java fa6d13f7cec40ae18f78da28b3b912e01be363aa geode-core/src/test/java/org/apache/geode/distributed/internal/DefaultPropertiesGeneratorIntegrationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java cae331325f17b470e6dd786d0f9a52bba7cb42a6 Diff: https://reviews.apache.org/r/56635/diff/ Testing ------- DefaultPropertiesGeneratorIntegrationTest GemFireVersionJUnitTest Thanks, Kirk Lund