[
https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867917#comment-15867917
]
ASF GitHub Bot commented on GEODE-2486:
---------------------------------------
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/11#discussion_r101287739
--- Diff: src/cryptoimpl/SSLImpl.cpp ---
@@ -52,25 +52,23 @@ SSLImpl::SSLImpl(ACE_SOCKET sock, const char
*pubkeyfile,
if (SSLImpl::s_initialized == false) {
ACE_SSL_Context *sslctx = ACE_SSL_Context::instance();
- SSL_CTX *opensslctx = sslctx->context();
- if (SSL_CTX_set_cipher_list(opensslctx, "eNULL:DEFAULT") == 0) {
- // if it fails here error is caught at connect.
- }
- // sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
+ SSL_CTX_set_cipher_list(sslctx->context(), "DEFAULT");
+ sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
--- End diff --
+1 for setting the mode
> SSL ciphers other than NULL not supported
> -----------------------------------------
>
> Key: GEODE-2486
> URL: https://issues.apache.org/jira/browse/GEODE-2486
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Jacob S. Barrett
>
> SSLImpl does not correctly initialize the OpenSSL library so ciphers other
> than the NULL cipher can be used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
