Github user metatype commented on a diff in the pull request:

    https://github.com/apache/geode/pull/398#discussion_r101391406
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
---
    @@ -1330,21 +1360,12 @@ private void startMemcachedServer() {
       }
     
       private void startRedisServer() {
    -    int port = system.getConfig().getRedisPort();
    -    if (port != 0) {
    -      String bindAddress = system.getConfig().getRedisBindAddress();
    -      assert bindAddress != null;
    -      if 
(bindAddress.equals(DistributionConfig.DEFAULT_REDIS_BIND_ADDRESS)) {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_PORT_0,
    -            new Object[] {port});
    -      } else {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_BIND_ADDRESS_0_PORT_1,
    -            new Object[] {bindAddress, port});
    -      }
    -      this.redisServer = new GeodeRedisServer(bindAddress, port);
    -      this.redisServer.start();
    +    GeodeRedisService geodeRedisService = 
getService(GeodeRedisService.class);
    --- End diff --
    
    Good news!  There *is* a way to start services and do gfsh extensions.  
Take a look at the lucene module.  The only bits that are in `geode-core` are 
for serialization and string messages--which we don't have a good solution for 
as of yet (contributions welcome!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to