-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56735/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, John Blum,
Kevin Duling, and Dan Smith.
Bugs: GEODE-2481
https://issues.apache.org/jira/browse/GEODE-2481
Repository: geode
Description
-------
GEODE-2481: extract default properties generation to its own class
While refactoring GemFireVersion for GEODE-2474, I noticed that
GemFireVersionIntegrationJUnitTest has nothing to do with GemFireVersion.
Extract generation of default properties to DefaultPropertiesGenerator.
Rename GemFireVersionIntegrationJUnitTest to
DefaultPropertiesGeneratorIntegrationTest. Add tests to increase code coverage.
DistributionConfig and DefaultPropertiesGenerator should eventually move to a
configuration package.
(If you try to pull this in to review it, you may need to 1st apply
https://reviews.apache.org/r/56734/ -- same link as "Depends On" to the right)
Diffs
-----
geode-assembly/build.gradle f34688043dd3e6bf8e8bdf0cb223d533b692e301
geode-core/src/main/java/org/apache/geode/distributed/internal/DefaultPropertiesGenerator.java
PRE-CREATION
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
fa6d13f7cec40ae18f78da28b3b912e01be363aa
geode-core/src/test/java/org/apache/geode/distributed/internal/DefaultPropertiesGeneratorIntegrationTest.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java
cae331325f17b470e6dd786d0f9a52bba7cb42a6
Diff: https://reviews.apache.org/r/56735/diff/
Testing
-------
precheckin passed
Thanks,
Kirk Lund
