[ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870945#comment-15870945
 ] 

ASF GitHub Bot commented on GEODE-2484:
---------------------------------------

Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/15#discussion_r101662122
  
    --- Diff: src/cppcache/src/TcrMessage.hpp ---
    @@ -1113,12 +1117,11 @@ class TcrMessageHelper {
           return NULL_OBJECT;
         } else if (!isObj) {
           // otherwise we're currently always expecting an object
    -      char exMsg[256];
    -      std::snprintf(exMsg, 255,
    -                    "TcrMessageHelper::readChunkPartHeader: "
    -                    "%s: part is not object",
    -                    methodName);
    -      LOGDEBUG("%s ", exMsg);
    +
    +      std::stringstream s;
    +      s << "TcrMessageHelper::readChunkPartHeader: " << methodName << ": 
part is not object\n";
    +      LOGDEBUG("%s ", s.str().c_str());
    --- End diff --
    
    Good question. I am still fascinated as to why std::snprintf isn't working 
correctly on Windows too.


> Remove ACE from native client dependencies
> ------------------------------------------
>
>                 Key: GEODE-2484
>                 URL: https://issues.apache.org/jira/browse/GEODE-2484
>             Project: Geode
>          Issue Type: Task
>          Components: native client
>            Reporter: David Kimura
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to