I have to say I’m -1 on this change for the following reasons: - Was not posted for review that I can see - Includes System.err statements - Includes changes that don’t seem relevant to the purpose of the commit? - Does not update LICENSE for removal of org.json
A matter of style it would be nice to have a more explanatory statement as well. Anthony > On Feb 17, 2017, at 1:01 PM, ASF subversion and git services (JIRA) > <j...@apache.org> wrote: > > > [ > https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872512#comment-15872512 > ] > > ASF subversion and git services commented on GEODE-2142: > -------------------------------------------------------- > > Commit b3ec80bc72fee3a40da297945a85d8df6c2a6460 in geode's branch > refs/heads/develop from [~ukohlmeyer] > [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b3ec80b ] > > GEODE-2142: Removal of non-compliant org.json implementation. > > >> Remove JSON.org dependency >> -------------------------- >> >> Key: GEODE-2142 >> URL: https://issues.apache.org/jira/browse/GEODE-2142 >> Project: Geode >> Issue Type: Bug >> Components: build >> Reporter: Anthony Baker >> Priority: Blocker >> Labels: json >> >> ASF has determined that the JSON library should be treated as Category X and >> is incompatible with ASLv2. >> We have until Apr-30, 2017 to remove this dependency. Any release we ship >> prior to that time must state this usage via NOTICE. >> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e >> There are related reasons for removing the JSON library anyway, but this bug >> captures the legal reasons. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.15#6346)
