Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/19#discussion_r102271148
  
    --- Diff: src/cppcache/integration-test/CMakeLists.txt ---
    @@ -21,7 +21,7 @@ target_link_libraries(${TEST_UTILS_LIB}
       PRIVATE
         ACE
       PUBLIC
    -    apache-geode
    +    ${PRODUCT_LIB_NAME}
    --- End diff --
    
    Rather than changing the target name of the library throughout CMake by 
using a variable I suggest just controlling the output name of the binary using 
the OUTPUT_NAME property.
    
    set_target_properties(apache-geode PROPERTIES OUTPUT_NAME 
${PRODUCT_LIB_NAME})
    
    This way the target stays "apache-geode" but the results of the output will 
be adjusted.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to