[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880932#comment-15880932
]
ASF GitHub Bot commented on GEODE-2439:
---------------------------------------
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102774330
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
- GfErrType getFuncAttributes(const char* func, std::vector<int8>** attr);
+ GfErrType getFuncAttributes(const char* func, std::vector<int8_t>**
attr);
--- End diff --
Yes, this is nearly 3 star code!
> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
