Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/27#discussion_r102825908
  
    --- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
    @@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory 
{
       Statistics* createStatistics(StatisticsType* type, const char* textId);
     
       Statistics* createStatistics(StatisticsType* type, const char* textId,
    -                               int64 numericId);
    +                               int64_t numericId);
     
       Statistics* createOsStatistics(StatisticsType* type, const char* textId,
    -                                 int64 numericId);
    +                                 int64_t numericId);
     
       Statistics* createAtomicStatistics(StatisticsType* type);
     
       Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId);
     
       Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId,
    -                                     int64 numericId);
    +                                     int64_t numericId);
     
       //------------ StatisticsFactory methods: Statistics Type
       //------------------------------
       StatisticsType* createType(const char* name, const char* description,
    -                             StatisticDescriptor** stats, int32 
statsLength);
    +                             StatisticDescriptor** stats, int32_t 
statsLength);
     
       StatisticsType* findType(const char* name);
     
       //------------ StatisticsFactory methods: Statistics Descriptor
       //---------------------
       StatisticDescriptor* createIntCounter(const char* name,
                                             const char* description,
    -                                        const char* units, int8 
largerBetter);
    +                                        const char* units, int8_t 
largerBetter);
    --- End diff --
    
    Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to