> On Feb. 23, 2017, 7:30 p.m., Jason Huynh wrote: > > Looks good. Would it be helpful to add which event caused the exception as > > well?
That might be a good idea - although it some cases it might not be a single event, but the whole batch. If we want that I can add it in a later commit. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/#review166556 ----------------------------------------------------------- On Feb. 23, 2017, 5:21 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56989/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 5:21 p.m.) > > > Review request for geode, Jason Huynh and Lynn Hughes-Godfrey. > > > Repository: geode > > > Description > ------- > > Adding a way for tests to observe the last seen exception from the > LuceneAsyncEventListener. > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java > 4a6a8358033a9ed0525b8b66f1b899b3b99728f7 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneExceptionObserver.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneEventListenerJUnitTest.java > 2b7af4a8bd3db8bfe9886250f2aa0f0c48fca7f6 > > Diff: https://reviews.apache.org/r/56989/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
