----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/#review166593 -----------------------------------------------------------
geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java (line 43) <https://reviews.apache.org/r/57001/#comment238595> Not sure but maybe just name it PaginationDUnitTest. Then we can have tests that don't handle pagination but not necessarily with Persistent regions in the same class? It would just require the @Parameters(values="PARTITION") or whatever. geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java (line 134) <https://reviews.apache.org/r/57001/#comment238598> maybe pull out the 4 into a variable? Is this value affecting or affected by the number of entries put into the region and/or page size? - Jason Huynh On Feb. 23, 2017, 10:24 p.m., nabarun nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57001/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 10:24 p.m.) > > > Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The following cases are being tested in the newly created > PaginationOnPersistentRegionDUnitTest.java: > > 1. The only single data store goes offline while paginating -> expected : > NoSuchElementException > 2. One data store goes offline while one still remains online while > paginating -> expected : all keys must be retrieved successfully. > 3. Two data stores exists but we alternatively shut one down and bring the > other up in between getting a page -> expected : all keys must be > successfully retrieved. > > > Diffs > ----- > > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java > 6d8278e > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/57001/diff/ > > > Testing > ------- > > spotlessApply > geode-lucene:prechecin > > > Thanks, > > nabarun nag > >
