Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/32#discussion_r103031314
  
    --- Diff: src/tests/cpp/fwklib/Timer.hpp ---
    @@ -28,18 +28,18 @@
     
     #ifdef _WIN32
     
    -#include <time.h>
    -#include <stdio.h>
    -#include <stdlib.h>
    +#include <ctime>
    +#include <cstdio>
    +#include <cstdlib>
     #include <windows.h>
     #include <winbase.h>
     
     #endif
     
     #ifdef _SOLARIS
     
    -#include <time.h>
    -#include <stdio.h>
    +#include <ctime>
    --- End diff --
    
    I bet this could be cleaned up by moving time, cstudio, cstdlib out of the 
conditionals since all platforms have those includes now.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to