Github user PivotalSarge commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/37#discussion_r103254380
  
    --- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
    @@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public 
SharedBase {
       virtual void setLastAccessedTime(uint32_t lat);
       virtual void setLastModifiedTime(uint32_t lmt);
     
    -  volatile uint32_t m_lastAccessTime;
    -  volatile uint32_t m_lastModifiedTime;
    +  std::atomic<uint32_t> m_lastAccessTime;
    +  std::atomic<uint32_t> m_lastModifiedTime;
    --- End diff --
    
    std::atomic is pretty cool. It looks like the performance impact is 
negligible, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to