[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890840#comment-15890840
 ] 

ASF GitHub Bot commented on GEODE-2231:
---------------------------------------

Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode-examples/pull/3#discussion_r103763443
  
    --- Diff: 
partitioned/src/main/java/org/apache/geode/examples/partitioned/BaseClient.java 
---
    @@ -0,0 +1,79 @@
    +/*
    --- End diff --
    
    Nitpick - I feel like this BaseClient actually makes the code less 
readable. It might be better to just create the caches and regions inline in 
the producer and consumer, and just have a static class that has the common 
properties.
    
    Also, getRegion1 and getRegion2 aren't very descriptive method names.


> Create new partitioning example
> -------------------------------
>
>                 Key: GEODE-2231
>                 URL: https://issues.apache.org/jira/browse/GEODE-2231
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs
>            Reporter: Karen Smoler Miller
>            Assignee: Karen Smoler Miller
>            Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to