[
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891072#comment-15891072
]
ASF subversion and git services commented on GEODE-2551:
--------------------------------------------------------
Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into
develop
* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
GEODE-2551 Fix code issues found by AppChecker
Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of
type client and DataPolicy is Empty."
GEODE-2538: Don't deserialize values on the server when getting results
GEODE-2461: remove json4s-ast_2.10 as explicit dependency
GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
GEODE-2526: Enhance log statement to include ResourceTypeName
GEODE-880 Remove unused classes
GEODE-2460: update dependency versions
GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory,
ReliableMessageQueueFactoryImpl and it's usage in the code from
GemfireCacheImpl and DistributedRegion.
GEODE-2550 Improve README and BUILDING
GEODE-2538: Don't invoke a cache loader when fetching values for a lucene
query
GEODE-2404: Added support for destroying lucene indexes
GEODE-2545: NPE during lucene query execution when cache is closing or region
is destroyed
GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
GEODE-2142: Removing JSON licence stuff from NOTICE files
GEODE-2142: removing tests so run precheckin
GEODE-2142: final compiling build
GEODE-2142: cyclical dependency in gradle build
GEODE-2142: spotless
GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing
file export to use Base64 encoding.
...
> Possible bugs in the source code
> --------------------------------
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
> Issue Type: Bug
> Components: gfsh, serialization
> Reporter: AppChecker
> Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1)
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2)
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3)
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) ||
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class) is checked twcie
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
