----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57249/#review167718 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On March 2, 2017, 11:12 a.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57249/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 11:12 a.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > Removed the --with-lsof option from netstat command to reduce the > command response size. Avoids OOME's on JVMs in the test environment > with small heaps. > > The original tests with lsof have been retained, but annotated with > @Ignore. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java > c6248e052ea8d8579c4f5b2b4de9ec74dca30e72 > > > Diff: https://reviews.apache.org/r/57249/diff/1/ > > > Testing > ------- > > Tested locally on JVMs with small heap to verify there are no OOMEs > Precheckin has been started. > > > Thanks, > > Ken Howe > >