----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57390/#review168170 -----------------------------------------------------------
Ship it! Ship It! Consider change to AssertJ in order to use containsIgnoringCase assertion. geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java Line 81 (original), 81 (patched) <https://reviews.apache.org/r/57390/#comment240326> Another option is to make this a weaker assertion: ```java assertThat(restClient.getContentType(response)).containsIgnoringCase(MediaType.APPLICATION_JSON_UTF8_VALUE); ``` - Kirk Lund On March 7, 2017, 5:48 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57390/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 5:48 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java > 75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 > gradle/dependency-versions.properties > 34e5d67882c5d1cd82cce04e31ebc69dab6f4251 > > > Diff: https://reviews.apache.org/r/57390/diff/1/ > > > Testing > ------- > > precheckin running > > Ran the test 20 times by hand locally without failure: `./gradlew > geode-assembly:integrationTest > -DintegrationTest.single=RestSecurityIntegrationTest` > > > Thanks, > > Kevin Duling > >
