----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57393/#review168178 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On March 7, 2017, 7:58 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57393/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 7:58 p.m.) > > > Review request for geode, anilkumar gingade and Eric Shu. > > > Bugs: GEODE-2616 > https://issues.apache.org/jira/browse/GEODE-2616 > > > Repository: geode > > > Description > ------- > > postDestroyRegion now removes itself from colocated parent colocatedByList > Improved colocatedByList by getting rid of unneeded synchronization and > making the field final. added unit test > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java > 8bfd4fa2d590455914d03cc761c35d70fa6df19f > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > 9374d4b653f5823295b1c205b93c96509629ad4f > > geode-core/src/test/java/org/apache/geode/internal/cache/ColocatedPRJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionTestHelper.java > 42c48acaf3a7b33cefffefdd7e3ffeb8d80e36a7 > > > Diff: https://reviews.apache.org/r/57393/diff/1/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
