Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104769132
--- Diff: src/cppcache/test/DataOutputTest.cpp ---
@@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance) {
"001B596F7520686164206D65206174206D65617420746F726E61646F2E",
dataOutput.getByteArray());
- EXPECT_EQ((2 + 27), dataOutput.getBufferLength());
-
- // buffers are pre-allocated 8k and have 2 bytes to hold the data length
- EXPECT_EQ(((8 * 1024) - (2 + 27)),
dataOutput.getRemainingBufferLength());
--- End diff --
getRemainingBufferLength() is the call that exhibited less-than-obvious
behavior. In particular, it appears to be affected by some global state. Its
return value was not predictable enough to be tested in that manner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
