[ https://issues.apache.org/jira/browse/GEODE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900507#comment-15900507 ]
Kirk Lund commented on GEODE-2558: ---------------------------------- I just created feature/GEODE-2558 branch with this 1st commit: {noformat} commit 1e2f9d6f7dcbcd17aec65cd6e567930d90a8282e Author: Kirk Lund <kl...@apache.org> Date: Fri Feb 24 21:10:50 2017 -0800 Upgrade mockito to 2.7.11 and powermock to 1.7.0RC2 * mockito-core.version = 2.7.11 * powermock.version = 1.7.0RC2 * fix compilation errors * there are several test failures in geode-core and geode-lucene geode-core test failures: * GMSMembershipManagerJUnitTest.testDirectChannelSend * GMSMembershipManagerJUnitTest.testDirectChannelSendAllRecipients * GMSMembershipManagerJUnitTest.testDirectChannelSendFailureDueToForcedDisconnect * GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToOneRecipient * Put61Test.integratedSecurityShouldSucceedIfAuthorized * Put61Test.noSecurityShouldSucceed * Put61Test.oldSecurityShouldSucceedIfAuthorized * Put65Test.integratedSecurityShouldSucceedIfAuthorized * Put65Test.noSecurityShouldSucceed * Put65Test.oldSecurityShouldSucceedIfAuthorized * PutTest.integratedSecurityShouldSucceedIfAuthorized * PutTest.noSecurityShouldSucceed * PutTest.oldSecurityShouldSucceedIfAuthorized * FastLoggerJUnitTest.delegateIsDebugEnabledWhenIsDelegating * FastLoggerJUnitTest.delegateIsDebugEnabledWhenIsDelegating * FastLoggerJUnitTest.delegateIsDebugEnabledWhenIsDelegating * OffHeapRegionEntryHelperJUnitTest.releaseEntryShouldSetValueToRemovePhase2 * OffHeapRegionEntryHelperJUnitTest.releaseEntryShouldSetValueToRemovePhase2AndSetsAsyncToFalseForDiskEntry * OffHeapRegionEntryHelperJUnitTest.setValueShouldChangeTheRegionEntryAddressToNewAddressAndDoesNothingIfOldAddressIsATokenAddress * OffHeapRegionEntryHelperJUnitTest.setValueShouldChangeTheRegionEntryAddressToNewAddressAndDoesNothingIfOldAddressIsAnEncodedAddress * OffHeapRegionEntryHelperJUnitTest.setValueShouldChangeTheRegionEntryAddressToNewAddressAndReleaseOldValueIfItsOnOffHeap * StatisticsImplTest.invokeSuppliersShouldLogErrorOnlyOnce * ConnectionJUnitTest.testSuspicionRaised geode-lucene test failures: * StringQueryProviderJUnitTest.usesCustomAnalyzer * RegionDirectoryJUnitTest.testFsyncDoesntCreateNewFiles * RegionDirectoryJUnitTest.testPendingDeletions {noformat} > Upgrade mockito dependency > -------------------------- > > Key: GEODE-2558 > URL: https://issues.apache.org/jira/browse/GEODE-2558 > Project: Geode > Issue Type: Wish > Components: build, tests > Reporter: Kirk Lund > Assignee: Kirk Lund > > Mockito should be upgrade from 1.x to 2.x. > 1.10.19 (Dec, 2014) <-- current version > 2.7.11 (Feb 2017) > This requires updating Powermock as well. > Changes to dependency-versions.properties: > {noformat} > -mockito-core.version = 1.10.19 > +mockito-core.version = 2.7.11 > ... > -powermock.version = 1.6.6 > +powermock.version = 1.7.0RC2 > {noformat} > The upgrade from Mockito 1.x to 2.x includes breaking APIs. Even after > updating the APIs to compile, I still see a number of unit tests that use > Mockito failing. These tests span all of the components in Geode so it's a > non-trivial upgrade. -- This message was sent by Atlassian JIRA (v6.3.15#6346)