Review Request 57437: GEODE-2594: do not use Attach API or tools.jar by default and deprecate --pid command options

Wed, 08 Mar 2017 16:02:58 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57437/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
and Swapnil Bawaskar.


Bugs: GEODE-2594
    https://issues.apache.org/jira/browse/GEODE-2594


Repository: geode


Description
-------

Remove tools.jar from gfsh classpath

Deprecate --pid option for status and stop commands

Remove usage of Attach API from start commands
    
* rename LauncherLifecycleCommandsTest
* add todo comment to ProcessUtils
* deprecate AttachAPINotFoundException
* remove usage of Attach API from LauncherLifecycleCommands


Diffs
-----

  geode-assembly/src/main/dist/bin/gfsh 
309723e9033bb44f25e2f8cbb797abf888735130 
  geode-assembly/src/main/dist/bin/gfsh.bat 
5a401413fd7d58ae753fe50538f76fbced334746 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
 1872a8484905b45bed5cf2874e89ab5049c178c2 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java
 947da4243010e06b53a4309374999437669503d0 
  geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
64e20f305b8f07298c61421a29888d5eae3dacad 
  geode-core/src/main/java/org/apache/geode/internal/process/ProcessUtils.java 
f15489f757bee3bdc806f90e2ef84b0111c35a93 
  
geode-core/src/main/java/org/apache/geode/lang/AttachAPINotFoundException.java 
576c19e162057dbdf2cec0cd7bb1e83aab3ebb91 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 e677ba399e0955d495eb42b57bfbce52d652a2a4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 7696aa87aee7bd270ca206c9761a91775f7f5f9a 
  
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java 
f487df9c0bae6b133697dafe3705d85b24f0b11b 


Diff: https://reviews.apache.org/r/57437/diff/1/


Testing
-------

precheckin in progress


Thanks,

Kirk Lund

Reply via email to