Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105009858
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -95,18 +98,38 @@ public RegionProvider(Region<ByteArrayWrapper,
ByteArrayWrapper> stringsRegion,
Region<ByteArrayWrapper, HyperLogLogPlus> hLLRegion,
Region<String, RedisDataType> redisMetaRegion,
ConcurrentMap<ByteArrayWrapper, ScheduledFuture<?>> expirationsMap,
- ScheduledExecutorService expirationExecutor, RegionShortcut
defaultShortcut) {
+ ScheduledExecutorService expirationExecutor, RegionShortcut
defaultShortcut,
+ Region<ByteArrayWrapper, Map<ByteArrayWrapper, ByteArrayWrapper>>
hashRegion,
+ Region<ByteArrayWrapper, Set<ByteArrayWrapper>> setRegion) {
+
+ this(stringsRegion, hLLRegion, redisMetaRegion, expirationsMap,
expirationExecutor,
+ defaultShortcut, hashRegion, setRegion,
GemFireCacheImpl.getInstance());
--- End diff --
ð for making the cache an argument to the constructor (even if it's
optional). Anything that makes things a little more decoupled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
