Github user PivotalSarge commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/50#discussion_r105266335
  
    --- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
    @@ -165,15 +165,15 @@ int main(int argc, char** argv) {
         LOGINFO("Registered Person Query Objects");
     
         // Populate the Region with some Person objects.
    -    Person* p1 = new Person("John", 1 /*ID*/, 23 /*age*/);
    +    Person* p1 = new Person((char *)"John", 1 /*ID*/, 23 /*age*/);
    --- End diff --
    
    Those methods pass a string literal to a method whose first parameter is 
char *. An alternative would be to modify the type of the parameter but that 
was a more invasive change when the goal was to reduce the clutter in the log 
that got in the way of determining the root cause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to