> On March 13, 2017, 8:52 p.m., Anthony Baker wrote: > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > > Line 453 (original), 464 (patched) > > <https://reviews.apache.org/r/57466/diff/2/?file=1662775#file1662775line464> > > > > How much did this change improve performance? > > > > I didn't review all the member variables, but `isIntegratedSecurity` > > does not appear to be thread-safe. > > > > That needs to be fixed, and then we should defintely revisit > > performance as it could introduce a contention bottleneck.
We don't have JMH implemented for the numbers yet. Will continue to enhance this. This is just to get rid of the string manipulation and object creation before we actually check for isSecurityEnabled. I don't see any need for isIntegratedSecurity to be thread-safe, multiple threads can call this method and they should arrive at the same conclusion, and after the flag is not null anymore, they will just do read operations. Correct me if I am wrong here... - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/#review168829 ----------------------------------------------------------- On March 13, 2017, 5:54 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57466/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 5:54 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > * clean up interface, reduce function call > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 8366930a3bf6a244d077c745fc810d77c4699c38 > geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java > 45da464419779773c9116d824fcf11774bafbd79 > > > Diff: https://reviews.apache.org/r/57466/diff/2/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
