[ 
https://issues.apache.org/jira/browse/GEODE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932795#comment-15932795
 ] 

ASF GitHub Bot commented on GEODE-2657:
---------------------------------------

Github user echobravopapa commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/63#discussion_r106924902
  
    --- Diff: 
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
    @@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client2OpTest)
     
           LOGINFO("FETimeOut begin onServer");
           ExecutionPtr serverExc = 
FunctionService::onServer(getHelper()->cachePtr);
    -      CacheableVectorPtr vec = 
serverExc->withArgs(CacheableInt32::create(5000))
    -                                   ->execute(FETimeOut, 5000)
    -                                   ->getResult();
    +      CacheableVectorPtr vec =
    +          serverExc->withArgs(CacheableInt32::create(5000 * 1000))
    --- End diff --
    
    might consider making a constant or two for these literals... in case 
someone is maintaining the test later on and needs/wants to adjust times used


> Execute Region Function sends incorrect message format
> ------------------------------------------------------
>
>                 Key: GEODE-2657
>                 URL: https://issues.apache.org/jira/browse/GEODE-2657
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: David Kimura
>            Assignee: Jacob S. Barrett
>
> `TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. 
> This causes the message response to be parsed synchronously and not 
> asynchronously chunked. The synchronous parser does not support this message 
> type and it barfs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to