----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57864/ -----------------------------------------------------------
Review request for geode, Darrel Schneider and Eric Shu. Repository: geode Description ------- GEODE-2472: The Oplog and OverflowOplog flush(OplogFile olf, ByteBuffer b1, ByteBuffer b2) method doesn't check the results of the channel.write() call. It could so happen partial byte array is written to the channel. The check is added to make sure the bytes are completely written to the file channel. Diffs ----- geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 27f41a2 geode-core/src/main/java/org/apache/geode/internal/cache/OverflowOplog.java c7f8e0d geode-core/src/test/java/org/apache/geode/internal/cache/OplogFlushTest.java d24e66d Diff: https://reviews.apache.org/r/57864/diff/1/ Testing ------- Run new unit tests added. precheckin in progress. Thanks, anilkumar gingade
