[
https://issues.apache.org/jira/browse/GEODE-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938943#comment-15938943
]
ASF GitHub Bot commented on GEODE-1274:
---------------------------------------
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/432
GEODE-1274: Migration from PulseLogWriter to Log4j standard.
To avoid dependency on geode-core, the pulse loggers are instantiated
directly from LogManager, rather than canonical LogService (which itself
extends LogManager).
Included in this patch:
- Removal of PulseLogWriter and associated classes
- Significant reduction of explicit logging level state checks, relying
instead on Log4j handling.
- Significant reduction of string concatenation, relying instead on Log4j2
string substitution.
- Reduction of logging using an exception's e.getMessage(), favoring
instead to pass the exception itself to the logger for the stacktrace.
- Multiple identical exception blocks collapsed to single exception catch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode bugfix/GEODE-1274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #432
----
commit 396ab06677e1e21fff060ba6ca1fb159f99a9997
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-03-22T20:27:34Z
GEODE-1274: Migration from PulseLogWriter to Log4j standard and removal of
associated classes.
To avoid dependency on geode-core, the pulse loggers are instantiated
directly from LogManager, rather than canonical LogService (which itself
extends LogManager).
Significant reduction of logging level state checks, relying on Log4j
handling.
Significant reduction of string concatenation, relying on Log4j2 string
substitutions.
Reduction of logging using an exception e.getMessage, favoring instead
passing the exception itself for the stacktrace.
Multiple identical exception blocks collapsed.
----
> Pulse logging does not appear in Geode log file.
> ------------------------------------------------
>
> Key: GEODE-1274
> URL: https://issues.apache.org/jira/browse/GEODE-1274
> Project: Geode
> Issue Type: Bug
> Components: logging, pulse
> Affects Versions: 1.0.0-incubating, 1.1.0
> Reporter: Jens Deppe
> Labels: Log4j2
>
> While trying to enable debug logging for Pulse, I found that no Pulse logging
> appears in the Geode log. The Admin REST logging does appear though.
> I had tried to enable debug logging by starting a locator with the followiing
> log4j config:
> {noformat}
> <?xml version="1.0" encoding="UTF-8"?>
> <Configuration status="FATAL" shutdownHook="disable"
> packages="com.gemstone.gemfire.internal.logging.log4j">
> <Properties>
> <Property name="gemfire-pattern">[%level{lowerCase=true} %date{yyyy/MM/dd
> HH:mm:ss.SSS z} <%thread> tid=%tid] %message%n%throwable%n</Property>
> </Properties>
> <Appenders>
> <Console name="STDOUT" target="SYSTEM_OUT">
> <PatternLayout pattern="${gemfire-pattern}"/>
> </Console>
> </Appenders>
> <Loggers>
> <Logger name="com.gemstone" level="INFO" additivity="true">
> <filters>
> <MarkerFilter marker="GEMFIRE_VERBOSE" onMatch="DENY"
> onMismatch="NEUTRAL"/>
> </filters>
> </Logger>
> <Logger name="org.springframework" level="DEBUG" additivity="true"/>
> <Root level="ERROR">
> <AppenderRef ref="STDOUT"/>
> </Root>
> </Loggers>
> </Configuration>
> {noformat}
> However, only the Admin REST app produced debug log output.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
