----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58050/ -----------------------------------------------------------
(Updated March 30, 2017, 6:17 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Swapnil Bawaskar. Changes ------- Added appropriate unittests, reverted collapse of exceptions in files otherwise untouched, corrected --dir behavior to not also address GEODE-2663. Repository: geode Description (updated) ------- export logs --dir refers to local filesystem when connected via HTTP and refers to the managers filesystem when connected via JMX. This behavior will be changed in GEODE-2663. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java 3f147c19a128dce78c51c31e6758e517cd2ab496 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java 268fa397db253f12c0effdbf6faa5e822730144c Diff: https://reviews.apache.org/r/58050/diff/2/ Changes: https://reviews.apache.org/r/58050/diff/1-2/ Testing (updated) ------- precheckin running. Manual verification of behavior both with and without --dir option, both connected via HTTP and not. Thanks, Patrick Rhomberg
